fix: enable-url-completion input treating the string "false" as true (#307)
Some checks failed
Publish Docker Image / publish (push) Has been cancelled

* NO-ISSUE Add test

* NO-ISSUE Use core.getBooleanInput() to retrieve boolean input values

* NO-ISSUE npm run build

* NO-ISSUE Delete unused import
This commit is contained in:
Yuta Kasai
2025-03-31 19:22:50 +09:00
committed by GitHub
parent d40710dfb0
commit 0505d8b048
5 changed files with 36 additions and 13 deletions

View File

@@ -18,7 +18,7 @@ export function getInputs(): Inputs {
repository: core.getInput('repository'),
shortDescription: core.getInput('short-description'),
readmeFilepath: core.getInput('readme-filepath'),
enableUrlCompletion: Boolean(core.getInput('enable-url-completion')),
enableUrlCompletion: core.getBooleanInput('enable-url-completion'),
imageExtensions: core.getInput('image-extensions')
}
@@ -54,7 +54,8 @@ export function getInputs(): Inputs {
}
if (!inputs.enableUrlCompletion && process.env['ENABLE_URL_COMPLETION']) {
inputs.enableUrlCompletion = Boolean(process.env['ENABLE_URL_COMPLETION'])
inputs.enableUrlCompletion =
process.env['ENABLE_URL_COMPLETION'].toLowerCase() === 'true'
}
if (!inputs.imageExtensions && process.env['IMAGE_EXTENSIONS']) {
@@ -65,9 +66,6 @@ export function getInputs(): Inputs {
if (!inputs.readmeFilepath) {
inputs.readmeFilepath = readmeHelper.README_FILEPATH_DEFAULT
}
if (!inputs.enableUrlCompletion) {
inputs.enableUrlCompletion = readmeHelper.ENABLE_URL_COMPLETION_DEFAULT
}
if (!inputs.imageExtensions) {
inputs.imageExtensions = readmeHelper.IMAGE_EXTENSIONS_DEFAULT
}

View File

@@ -4,7 +4,6 @@ import * as utils from './utils'
export const README_FILEPATH_DEFAULT = './README.md'
export const IMAGE_EXTENSIONS_DEFAULT = 'bmp,gif,jpg,jpeg,png,svg,webp'
export const ENABLE_URL_COMPLETION_DEFAULT = false
const TITLE_REGEX = `(?: +"[^"]+")?`
const REPOSITORY_URL = `${process.env['GITHUB_SERVER_URL']}/${process.env['GITHUB_REPOSITORY']}`