bf1942/bili-sync-ai
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: 使用 itertools 提供的 join，避免 collect 到 Vec 的额外分配 (#652)

Browse Source
This commit is contained in:
ᴀᴍᴛᴏᴀᴇʀ
2026-02-19 19:04:10 +08:00
committed by GitHub
parent 5350d3491b
commit bb1576a0df
3 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
crates/bili_sync/src/api/helper.rs
View File

@@ -116,10 +116,7 @@ async fn execute_page_update_batch(
txn: &DatabaseTransaction, txn: &DatabaseTransaction,
pages: impl Iterator<Item = (i32, u32)>, pages: impl Iterator<Item = (i32, u32)>,
) -> Result<(), sea_orm::DbErr> { ) -> Result<(), sea_orm::DbErr> {
let values = pages let values = pages.map(|p| format!("({}, {})", p.0, p.1)).join(", ");
.map(|p| format!("({}, {})", p.0, p.1))
.collect::<Vec<_>>()
.join(", ");
if values.is_empty() { if values.is_empty() {
return Ok(()); return Ok(());
} }

7
crates/bili_sync/src/api/routes/video_sources/mod.rs
View File

@@ -7,6 +7,7 @@ use axum::routing::{get, post, put};
use bili_sync_entity::rule::Rule; use bili_sync_entity::rule::Rule;
use bili_sync_entity::*; use bili_sync_entity::*;
use bili_sync_migration::Expr; use bili_sync_migration::Expr;
use itertools::Itertools;
use sea_orm::ActiveValue::Set; use sea_orm::ActiveValue::Set;
use sea_orm::entity::prelude::*; use sea_orm::entity::prelude::*;
use sea_orm::{ColumnTrait, DatabaseConnection, EntityTrait, QuerySelect, QueryTrait, TransactionTrait}; use sea_orm::{ColumnTrait, DatabaseConnection, EntityTrait, QuerySelect, QueryTrait, TransactionTrait};
@@ -347,11 +348,7 @@ pub async fn evaluate_video_source(
SET should_download = tempdata.should_download \ SET should_download = tempdata.should_download \
FROM tempdata \ FROM tempdata \
WHERE video.id = tempdata.id", WHERE video.id = tempdata.id",
chunk chunk.iter().map(|item| format!("({}, {})", item.0, item.1)).join(", ")
.iter()
.map(|item| format!("({}, {})", item.0, item.1))
.collect::<Vec<_>>()
.join(", ")
); );
txn.execute_unprepared(&sql).await?; txn.execute_unprepared(&sql).await?;
} }

9
crates/bili_sync/src/config/current.rs
View File

@@ -3,6 +3,7 @@ use std::sync::{Arc, LazyLock};
use anyhow::{Result, bail}; use anyhow::{Result, bail};
use croner::parser::CronParser; use croner::parser::CronParser;
use itertools::Itertools;
use sea_orm::DatabaseConnection; use sea_orm::DatabaseConnection;
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use validator::Validate; use validator::Validate;
@@ -103,13 +104,7 @@ impl Config {
} }
}; };
if !errors.is_empty() { if !errors.is_empty() {
bail!( bail!(errors.into_iter().map(|e| format!("- {}", e)).join("\n"));
errors
.into_iter()
.map(|e| format!("- {}", e))
.collect::<Vec<_>>()
.join("\n")
);
} }
Ok(()) Ok(())
} }